Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): Basic implementation for pull-based executor and remove internal executor endpoints #758

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Jan 15, 2025

Description

  • Use Ray's RuntimeEnv to manage custom udf repository, instead of having to push to executor to sync updates.
  • Instead, when a user syncs the repo, we still pull the repo and update the action interfaces for the builder and registry, but we don't allow pushing to executor.
  • We update the executor so that it checks the db repo for a SHA.
  • For stability, we enforce that we pass a SHA with the git url into the ray RuntimeEnv. If no SHA is available, we don't install the remote repo as a dep.
    • Ray caches the dependencies depending on the hash of the RuntimeEnv. If a change is observed, it will automatically pip install the updated version. For this reason, we always pass a SHA into the git url.

Changes

  • Remove sync executors and validation from executor

@topher-lo topher-lo added the engine Improvements or additions to the workflow engine label Jan 15, 2025
@topher-lo
Copy link
Contributor

Note that we can further tighten our Docker subnets and AWS security groups after this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Improvements or additions to the workflow engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants